Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add session token injection to provisioner#7461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sreya merged 12 commits intomainfromjon/tfsessiontoken
May 18, 2023
Merged

Conversation

sreya
Copy link
Collaborator

@sreyasreya commentedMay 9, 2023•
edited
Loading

This PR adds the plumbing necessary for referencing thecoder_session_token data source in the TF provider.

fixes#6354

@sreyasreya changed the titlefeat: add session token to provisionerfeat: add session token injection to provisionerMay 9, 2023
@sreyasreya marked this pull request as ready for reviewMay 10, 2023 01:34
@sreyasreya requested a review fromkylecarbsMay 10, 2023 02:27
@sreyasreya requested a review frommtojekMay 16, 2023 04:10
Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice piece of code, Jon!

sreya reacted with heart emoji
@@ -220,6 +220,7 @@ func provisionEnv(config *proto.Provision_Config, params []*proto.ParameterValue
"CODER_WORKSPACE_OWNER_OIDC_ACCESS_TOKEN="+config.Metadata.WorkspaceOwnerOidcAccessToken,
"CODER_WORKSPACE_ID="+config.Metadata.WorkspaceId,
"CODER_WORKSPACE_OWNER_ID="+config.Metadata.WorkspaceOwnerId,
"CODER_SESSION_TOKEN="+config.Metadata.CoderSessionToken,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I doubt it, but maybe you want to confirm that we don't leak it somewhere in the provisioner logs presented in the debug mode (Try with debug mode).

@sreyasreya requested a review frommtojekMay 17, 2023 00:51
Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, all comments addressed.

@sreyasreya merged commitec5ef51 intomainMay 18, 2023
@sreyasreya deleted the jon/tfsessiontoken branchMay 18, 2023 04:29
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 18, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mtojekmtojekmtojek approved these changes

@kylecarbskylecarbsAwaiting requested review from kylecarbs

Assignees

@sreyasreya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pre-authenticatecoder CLI on the Workspace
2 participants
@sreya@mtojek
[8]ページ先頭
©2009-2025 Movatter.jp