- Notifications
You must be signed in to change notification settings - Fork1.1k
chore: Allow editing proxy fields via api.#7435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| // TODO: This audit log does not work because it has no user id | ||
| // associated with it. The audit log commitAudit() function ignores | ||
| // the audit log if there is no user id. We should find a solution | ||
| // to make sure this event is tracked. | ||
| //auditor = api.AGPL.Auditor.Load() | ||
| //aReq, commitAudit = audit.InitRequest[database.WorkspaceProxy](rw, &audit.RequestParams{ | ||
| //Audit: *auditor, | ||
| //Log: api.Logger, | ||
| //Request: r, | ||
| //Action: database.AuditActionWrite, | ||
| //}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Going to kick fixing this to another PR.
I commented out rather than deleting it to remind us that we probably should audit log this, but at the moment we cannot.
bpmct commentedMay 9, 2023
Can you also edit the default proxy name and icon? (it's difficult for me to check since the slim builds don't include |
Uh oh!
There was an error while loading.Please reload this page.
What this does
Adds cli command to edit workspace proxy fields.
Also add
coder wsproxy regenerate-token <name>to generate a new auth token for the wsproxyFixes#7406
Fixes#7407