- Notifications
You must be signed in to change notification settings - Fork926
fix: pubsub ordering#7404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
fix: pubsub ordering#7404
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Signed-off-by: Spike Curtis <spike@coder.com>
Signed-off-by: Spike Curtis <spike@coder.com>
kylecarbs approved these changesMay 4, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the pubsub so that it calls back messages in order.
This is important for applications that depend on message order (as opposed to just using the pubsub as a kick to go load updates).
In particular, the streaming provisioner job logs endpoint isvery complicated and still broken (c.f.#7371) trying to deal with out of order messages.
As a second example, the
haCoordinator
will fail even the most trivial example of a client or agent sending multiple node updates if the pubsub messages get reordered.This PR creates an in-order queue of messages per subscriber (just a fixed size
chan
) and runs a goroutine per subscriber (instead of per subscriberper message) to deliver them.If the queue gets backed up, we drop messages rather than block. This was chosen rather than blocking the whole pubsub for a single Listener that isn't keeping up. Since the
pg.Listener
is, under the covers, handling DB reconnects, the pubsub can already drop messages, so from a design standpoint it's nothing new. In another PR I plan to add the capability for subscribers to get notified if messages are dropped.