Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: adjust the style and wording of the license page#7396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kylecarbs merged 2 commits intomainfromlicensestyle
May 14, 2023

Conversation

kylecarbs
Copy link
Member

@kylecarbskylecarbs commentedMay 3, 2023•
edited
Loading

  • Reduce the size of the card to improve the use of space
  • Adjust the language of the add page to remove word redundancy
  • Change from using background colors to text colors
  • The license removal didn't indicate to users what it would actually do, so I added a message.

Check storybook to see the visual diff!

image

- Reduce the size of the card to improve the use of space- Adjust the language of the add page to remove word redundancy- Change from using background colors to text colors
Copy link
Contributor

@rodrimaiarodrimaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice changes. I liked the copy changes. :)

(just for clarification, the idea of having a biggercard at the beginning was to have nice UI for one license only since most users will only have one, not a list of them)

lgtm!
Maybe the only thing is that in this configuration , theRemove button looks a little bit not aligned.
image

but changing it is up to you. Seems fine as it is :)

@github-actions
Copy link

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelMay 12, 2023
@kylecarbskylecarbs removed the staleThis issue is like stale bread. labelMay 12, 2023
@kylecarbskylecarbs merged commit778cb74 intomainMay 14, 2023
@kylecarbskylecarbs deleted the licensestyle branchMay 14, 2023 20:31
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 14, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

1 more reviewer

@rodrimaiarodrimaiarodrimaia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kylecarbskylecarbs

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kylecarbs@rodrimaia
[8]ページ先頭
©2009-2025 Movatter.jp