NotificationsYou must be signed in to change notification settings
Fork927
Star10.1k

docs: make use of`display_name` and`name` in Open with Coder#7372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bpmct merged 1 commit intomainfrommatifali-docs-opne-in-coder

May 2, 2023

Merged

docs: make use of`display_name` and`name` in Open with Coder#7372

bpmct merged 1 commit intomainfrommatifali-docs-opne-in-coder

May 2, 2023

Conversation

Copy link

Member

matifali commentedMay 2, 2023•
edited
Loading

This makes the Open in Coder link easier to read and type, asname does not have any spaces now.
This PR removed the spaces fromname and makes it equal to the resource name as we now have a separate fielddisplay_name#6919

The docs referencehttps://github.com/bpmct/coder-templates/tree/main/kubernetes-open-in-coder example which does not yet makes use ofdisplay name and needs updating.

@bpmct, please update the example if required.

docs: make use ofdisplay_name andname in Open with Coder

5af61fa

This PR removed the spaces from `name` and makes it equal to the resource name as we now have a sperate field `display_name`#6919The docs referenceshttps://github.com/bpmct/coder-templates/tree/main/kubernetes-open-in-coder example which does not yet makes use of  `display name` and needs updating.