NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

feat: Add config-ssh command#735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

kylecarbs merged 2 commits intomainfromconfig-ssh

Mar 30, 2022

Merged

feat: Add config-ssh command#735

kylecarbs merged 2 commits intomainfromconfig-ssh

Mar 30, 2022

Conversation

Copy link

Member

kylecarbs commentedMar 30, 2022•
edited
Loading

Closes#254,#499, and#737.

kylecarbs requested a review fromcoadler

March 30, 2022 14:39

kylecarbs self-assigned this

Mar 30, 2022

Copy link

codecovbot commentedMar 30, 2022•
edited
Loading

Codecov Report

Merging#735 (6b0c76d) intomain (1bab7e8) willdecrease coverage by0.58%.
The diff coverage is57.76%.

@@            Coverage Diff             @@##             main     #735      +/-   ##==========================================- Coverage   64.53%   63.95%   -0.59%==========================================  Files         198      199       +1       Lines       11622    11826     +204       Branches       85       87       +2     ==========================================+ Hits         7500     7563      +63- Misses       3333     3437     +104- Partials      789      826      +37

Flag	Coverage Δ
unittest-go-	`63.03% <54.51%> (-0.58%)`	⬇️
unittest-go-macos-latest	`58.85% <54.34%> (-0.65%)`	⬇️
unittest-go-ubuntu-latest	`61.79% <54.51%> (-0.41%)`	⬇️
unittest-go-windows-2022	`58.03% <53.62%> (-0.32%)`	⬇️
unittest-js	`62.63% <ø> (-0.70%)`	⬇️

Impacted Files	Coverage Δ
agent/conn.go	`65.38% <ø> (-3.59%)`	⬇️
cli/workspacedelete.go	`17.64% <0.00%> (ø)`
cli/workspacestart.go	`15.15% <0.00%> (ø)`
cli/workspacestop.go	`13.88% <0.00%> (ø)`
provisioner/terraform/provision.go	`68.82% <0.00%> (ø)`
coderd/workspaceresources.go	`56.09% <26.92%> (-5.45%)`	⬇️
cli/ssh.go	`38.88% <35.00%> (-4.45%)`	⬇️
cli/start.go	`65.74% <50.00%> (-0.42%)`	⬇️
cli/configssh.go	`58.03% <55.23%> (+0.89%)`	⬆️
cli/cliui/agent.go	`82.45% <70.00%> (+0.31%)`	⬆️
... and29 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update1bab7e8...6b0c76d. Read thecomment docs.