Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(agent): add http debug routes for magicsock#7287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
coadler merged 3 commits intomainfromcolin/agent-http-debug2
Apr 26, 2023

Conversation

coadler
Copy link
Contributor

@coadlercoadler commentedApr 25, 2023
edited
Loading

Exposes Tailscale's magicsock debug, which can be helpful when debugging connections.

image

@coadlercoadler self-assigned thisApr 25, 2023
@coadlercoadlerforce-pushed thecolin/agent-http-debug2 branch 2 times, most recently from839ae15 to3138432CompareApril 25, 2023 23:18
@coadlercoadlerforce-pushed thecolin/agent-http-debug2 branch from9187327 toa3d2a9eCompareApril 25, 2023 23:41
Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ship it!

Copy link
Member

@mafredrimafredri left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think we should be careful about using up ports in user workspaces, but don't really have a suggestion for an improvement here. Maybe this debug endpoint could be enabled on-demand or something in future.

@coadler
Copy link
ContributorAuthor

I think we should be careful about using up ports in user workspaces, but don't really have a suggestion for an improvement here. Maybe this debug endpoint could be enabled on-demand or something in future.

Yeah, I was thinking about that while writing this. I think users probably wouldn't be too stoked we're automatically taking up some commonly used ports. Another thing we could do is use some of our reserved ports in Wireguard, but then a user couldn't port-forward to them.

@coadlercoadler merged commit3eb7f06 intomainApr 26, 2023
@coadlercoadler deleted the colin/agent-http-debug2 branchApril 26, 2023 18:01
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 26, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

@mtojekmtojekmtojek approved these changes

Assignees

@coadlercoadler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@coadler@mafredri@mtojek

[8]ページ先頭

©2009-2025 Movatter.jp