- Notifications
You must be signed in to change notification settings - Fork928
chore: fix flake in apptest reconnecting-pty test#7281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sure
| bufRead := bufio.NewReader(conn) | ||
| // Brief pause to reduce the likelihood that we send keystrokes while | ||
| // the shell is simultaneously sending a prompt. | ||
| time.Sleep(100 * time.Millisecond) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I guess we can't expect prompt first? If we could set env PS1=> then we'd have something to look for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
PS1 doesn't seem to be accepted through env in bash, only as a variable
Uh oh!
There was an error while loading.Please reload this page.
Makes the tests identical because the other ones work. I had to change the codersdk methods a bit to accomplish this.
https://github.com/coder/coder/actions/runs/4786259967/jobs/8510272554