NotificationsYou must be signed in to change notification settings
Fork1.1k
Star11.4k

fix(coderd): ensure that user API keys are deleted when a user is#7270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

johnstcn merged 1 commit intomainfromcj/invalidate_user_api_token

Apr 24, 2023

Merged

fix(coderd): ensure that user API keys are deleted when a user is#7270

johnstcn merged 1 commit intomainfromcj/invalidate_user_api_token

Apr 24, 2023

Conversation

Copy link

Member

johnstcn commentedApr 24, 2023

Fixes an issue where API tokens belonging to a deleted user were not invalidated:

Adds a trigger to delete rows from the api_key stable when the column deleted is set to true in the users table.
Adds a trigger to the api_keys table to ensure that new rows may not be added where user_id corresponds to a deleted user.
Adds a migration to delete all API keys from deleted users.
Adds tests + dbfake implementation for the above.

fix(coderd): ensure that user API keys are deleted when a user is

592168b

Fixes an issue where API tokens belonging to a deleted user werenot invalidated:- Adds a trigger to delete rows from the api_key stable when the  column deleted is set to true in the users table.- Adds a trigger to the api_keys table to ensure that new rows  may not be added where user_id corresponds to a deleted user.- Adds a migration to delete all API keys from deleted users.- Adds tests + dbfake implementation for the above.