- Notifications
You must be signed in to change notification settings - Fork928
fix(site): Do not show template params if there is no param to be shown#7263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -135,6 +135,10 @@ export const CreateWorkspacePageView: FC< | ||
| }) | ||
| const isLoading = props.loadingTemplateSchema || props.loadingTemplates | ||
| // We only want to show schema that have redisplay_value equals true | ||
| const schemaToBeDisplayed = props.templateSchema?.filter( | ||
| (schema) => schema.redisplay_value, | ||
| ) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. The linked bug ticket mentions that terraform values set to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Yeap, it should do! | ||
| const getFieldHelpers = getFormHelpers<TypesGen.CreateWorkspaceRequest>( | ||
| form, | ||
| @@ -271,29 +275,26 @@ export const CreateWorkspacePageView: FC< | ||
| )} | ||
| {/* Template params */} | ||
| {schemaToBeDisplayed &&schemaToBeDisplayed.length > 0 && ( | ||
| <FormSection | ||
| title="Template params" | ||
| description="These values are provided by your template's Terraform configuration." | ||
| > | ||
| <FormFields> | ||
| {schemaToBeDisplayed.map((schema) => ( | ||
| <ParameterInput | ||
| disabled={form.isSubmitting} | ||
| key={schema.id} | ||
| defaultValue={parameterValues[schema.name]} | ||
| onChange={(value) => { | ||
| setParameterValues({ | ||
| ...parameterValues, | ||
| [schema.name]: value, | ||
| }) | ||
| }} | ||
| schema={schema} | ||
| /> | ||
| ))} | ||
| </FormFields> | ||
| </FormSection> | ||
| )} | ||