Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: tailnet debug logging#7260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 10 commits intomainfromspike/debug-tailnet
Apr 27, 2023
Merged

chore: tailnet debug logging#7260

spikecurtis merged 10 commits intomainfromspike/debug-tailnet
Apr 27, 2023

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedApr 24, 2023•
edited
Loading

We've been seeing some flaky tests with tailnet connections that fail to come up. This PR

  1. Enables Tailscale Discovery (Disco) debug logging in CI
  2. Adds additional debug logging to agent and tailnet

@spikecurtisspikecurtis changed the titleDraft: Debugging tailnetfix: Debugging tailnetApr 24, 2023
Signed-off-by: Spike Curtis <spike@coder.com>
Signed-off-by: Spike Curtis <spike@coder.com>
Signed-off-by: Spike Curtis <spike@coder.com>
Signed-off-by: Spike Curtis <spike@coder.com>
Signed-off-by: Spike Curtis <spike@coder.com>
@spikecurtisspikecurtis changed the titlefix: Debugging tailnetchore: tailnet debug loggingApr 26, 2023
@spikecurtisspikecurtis marked this pull request as ready for reviewApril 26, 2023 11:22
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some minor suggestions to improve the messaging a bit and one slightly larger concern about write rpty logging, but other than that, looks good.

We should maybe try to take a look at how much this increases agent log size though as it's already pretty verbose.

spikecurtisand others added5 commitsApril 27, 2023 07:52
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
Signed-off-by: Spike Curtis <spike@coder.com>
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for making the changes, looks good. Can't wait to see if this helps us narrow down some issues 👍

@spikecurtisspikecurtis merged commitb6666cf intomainApr 27, 2023
@spikecurtisspikecurtis deleted the spike/debug-tailnet branchApril 27, 2023 09:59
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 27, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@spikecurtis@mafredri
[8]ページ先頭
©2009-2025 Movatter.jp