Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: coder_parameter fallbacks to default#7240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mtojek merged 1 commit intocoder:mainfrommtojek:7238-fix-default-parameter
Apr 24, 2023

Conversation

mtojek
Copy link
Member

@mtojekmtojek commentedApr 21, 2023•
edited
Loading

Fixes:#7238
Fixes:#7213

While I was investigating mentioned issues, I found some regression related to edge cases withdefault andlegacy that may give a bad user experience. I have covered the backend part with extra unit tests.

Changes:

  • backend: use default parameter value if it can't be found in the previous build request or among legacy parameters
  • frontend: adjust legacy migration logic, just defer it to the backend

@mtojekmtojek marked this pull request as ready for reviewApril 21, 2023 11:05
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@mtojekmtojek merged commitc000f2e intocoder:mainApr 24, 2023
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 24, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

Assignees

@mtojekmtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optional coder_parameters aren't truly optional? Adding or updating parameters in a template causes existing workspaces to re-enter all parameters
2 participants
@mtojek@BrunoQuaresma
[8]ページ先頭
©2009-2025 Movatter.jp