Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(site): Fix update when missing parameters#7221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bpmct merged 1 commit intomainfrombq/fix-template-update
Apr 20, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

Close#7213

@BrunoQuaresmaBrunoQuaresma requested review frommtojek anda teamApril 20, 2023 14:05
@BrunoQuaresmaBrunoQuaresma self-assigned thisApr 20, 2023
@BrunoQuaresmaBrunoQuaresma requested review fromrodrimaia and removed request fora teamApril 20, 2023 14:05
if (newParam === undefined) {
richParameterValues.push(oldParam)
}
})
Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Basically, we were not passing the old values when there is new ones.

Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Let's make sure first that this bugfix fixes what it should fix.

@bpmctbpmct merged commit7d9a763 intomainApr 20, 2023
@bpmctbpmct deleted the bq/fix-template-update branchApril 20, 2023 14:32
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 20, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mtojekmtojekmtojek left review comments

@bpmctbpmctbpmct approved these changes

@rodrimaiarodrimaiaAwaiting requested review from rodrimaiarodrimaia was automatically assigned from coder/ts

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding or updating parameters in a template causes existing workspaces to re-enter all parameters
3 participants
@BrunoQuaresma@mtojek@bpmct

[8]ページ先頭

©2009-2025 Movatter.jp