Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add license settings UI#7210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
rodrimaia merged 22 commits intomainfromadd_license_settings
Apr 26, 2023
Merged

feat: add license settings UI#7210

rodrimaia merged 22 commits intomainfromadd_license_settings
Apr 26, 2023

Conversation

rodrimaia
Copy link
Contributor

@rodrimaiarodrimaia commentedApr 19, 2023
edited
Loading

Kira-Pilot reacted with hooray emoji
@rodrimaiarodrimaia self-assigned thisApr 19, 2023
rodrimaiaand others added2 commitsApril 21, 2023 10:28
Co-authored-by: Ben Potter <ben@coder.com>
@rodrimaiarodrimaia changed the titleAdd license settings UIfeat: add license settings UIApr 21, 2023
@rodrimaiarodrimaia marked this pull request as ready for reviewApril 24, 2023 14:46
@rodrimaiarodrimaia requested review froma team,BrunoQuaresma andbpmct and removed request fora teamApril 24, 2023 14:46
@BrunoQuaresma
Copy link
Collaborator

BrunoQuaresma commentedApr 24, 2023
edited
Loading

I just have one minor thing, why not instead of having a button that opens a drag-and-drop area, why not display it directly there instead of the button? I also realized in the drag-and-drop area, the message is not centralized. And usually, in these kinda elements, the icon comes first and the message below is like we do in the create template page I guess.

@rodrimaia
Copy link
ContributorAuthor

rodrimaia commentedApr 24, 2023
edited
Loading

I just have one minor thing, why not instead of having a button that opens a drag-and-drop area, why not display it directly there instead of the button? I also realized in the drag-and-drop area, the message is not centralized. And usually, in these kinda elements, the icon comes first and the message below is like we do in the create template page I guess.

@BrunoQuaresma Thank you for the feedback, I indeed edited it to be a horizontal form like the one in the create template page. I need to record an updated loom video, but you can check the updated screenshots and stories in the meantime =D

@BrunoQuaresma
Copy link
Collaborator

Ahh, I see. A quick video explaining what I would do to make it look a bit better.

Screen.Recording.2023-04-24.at.11.58.35.mov
rodrimaia reacted with heart emoji

@Kira-Pilot
Copy link
Member

Couple of comments but overall, very nicely done! I especially love the drag-n-drop UI and the animation.

rodrimaia reacted with heart emoji

@rodrimaia
Copy link
ContributorAuthor

Ahh, I see. A quick video explaining what I would do to make it look a bit better.

Screen.Recording.2023-04-24.at.11.58.35.mov

image
Fixed! Thank you for suggesting

BrunoQuaresma reacted with heart emoji

@BrunoQuaresma
Copy link
Collaborator

@rodrimaia looks pretty!

@BrunoQuaresma
Copy link
Collaborator

One minor thing is when the licenses are empty looks like we are only showing the button 🤔. This is from storybookhttps://www.chromatic.com/test?appId=624de63c6aacee003aa84340&id=64494d5b3fb99efb4ad00fb9

Screen Shot 2023-04-26 at 13 25 37

@rodrimaia
Copy link
ContributorAuthor

One minor thing is when the licenses are empty looks like we are only showing the button 🤔. This is from storybookhttps://www.chromatic.com/test?appId=624de63c6aacee003aa84340&id=64494d5b3fb99efb4ad00fb9

Screen Shot 2023-04-26 at 13 25 37

image
fixed! :)

@bpmct
Copy link
Member

bpmct commentedApr 26, 2023
edited
Loading

Screenshot 2023-04-26 at 1 18 31 PM

Can you change it to

Contactsales orrequest a trial license to learn more

AlsoNo Licenses yet ->No licenses yet

@rodrimaia
Copy link
ContributorAuthor

Fixed! thanks Ben
image

Copy link
Member

@mtojekmtojek left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Backend LGTM, but please add a relevant unit test.

@mtojekmtojek self-requested a reviewApril 26, 2023 20:03
Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Backend LGTM

@rodrimaiarodrimaia merged commit87b7537 intomainApr 26, 2023
@rodrimaiarodrimaia deleted the add_license_settings branchApril 26, 2023 20:47
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 26, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@Kira-PilotKira-PilotKira-Pilot left review comments

@mtojekmtojekmtojek approved these changes

@BrunoQuaresmaBrunoQuaresmaAwaiting requested review from BrunoQuaresmaBrunoQuaresma was automatically assigned from coder/ts

@bpmctbpmctAwaiting requested review from bpmct

Assignees

@rodrimaiarodrimaia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@rodrimaia@BrunoQuaresma@Kira-Pilot@bpmct@mtojek

[8]ページ先頭

©2009-2025 Movatter.jp