Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(cli): Fix postgres TDE failing version check#7203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
coadler merged 4 commits intocoder:mainfromMTschirnich:postgres-version-num
Apr 19, 2023

Conversation

@MTschirnich
Copy link
Contributor

Hi,

I am running postgres 13 TDE and ran into the issue coder reporting the version is not v13 or higher.

After a bit of investigating I noticed coder uses "SHOW server_version".
Unfortunately the postgres TDE build reports it version other than a normal postgres build.
Postgres 13 TDE: "13.10_TDE_1.0.5 (Ubuntu.....)"
Postgres 12: "12.13 (Ubuntu...)"

In cli/server.go the version check splits at the space and proceeds to compare it with semver, which does not seem to like the additional content.

I addressed this by changing the server_version to server_version_num, as this is a number and the TDE information is not present. This also simplifies the comparison of the versions.

@github-actions
Copy link

github-actionsbot commentedApr 19, 2023
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@MTschirnich
Copy link
ContributorAuthor

I have read the CLA Document and I hereby sign the CLA

cdrcommunity added a commit to coder/cla that referenced this pull requestApr 19, 2023
@kylecarbskylecarbs requested a review fromcoadlerApril 19, 2023 15:56
@coadler
Copy link
Contributor

Thanks@MTschirnich!

@MTschirnich
Copy link
ContributorAuthor

Hello@coadler, I am not sure what the exact nature of the error in the test-go for Ubuntu is.
It seems to have worked before my fixes, so I am not sure what caused the fail now. And why nothing else failed.

Do you have an idea?

@coadler
Copy link
Contributor

Just looks like a flake. I'll rerun and merge 🙂

@MTschirnich
Copy link
ContributorAuthor

Thanks 😄

@coadlercoadler merged commitfff2b1d intocoder:mainApr 19, 2023
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 19, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@kylecarbskylecarbskylecarbs approved these changes

+1 more reviewer

@coadlercoadlercoadler approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MTschirnichMTschirnich

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MTschirnich@coadler@kylecarbs

[8]ページ先頭

©2009-2025 Movatter.jp