- Notifications
You must be signed in to change notification settings - Fork1.1k
fix(cli): Fix postgres TDE failing version check#7203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
github-actionsbot commentedApr 19, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
MTschirnich commentedApr 19, 2023
I have read the CLA Document and I hereby sign the CLA |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
coadler commentedApr 19, 2023
Thanks@MTschirnich! |
MTschirnich commentedApr 19, 2023
Hello@coadler, I am not sure what the exact nature of the error in the test-go for Ubuntu is. Do you have an idea? |
coadler commentedApr 19, 2023
Just looks like a flake. I'll rerun and merge 🙂 |
MTschirnich commentedApr 19, 2023
Thanks 😄 |
Hi,
I am running postgres 13 TDE and ran into the issue coder reporting the version is not v13 or higher.
After a bit of investigating I noticed coder uses "SHOW server_version".
Unfortunately the postgres TDE build reports it version other than a normal postgres build.
Postgres 13 TDE: "13.10_TDE_1.0.5 (Ubuntu.....)"
Postgres 12: "12.13 (Ubuntu...)"
In cli/server.go the version check splits at the space and proceeds to compare it with semver, which does not seem to like the additional content.
I addressed this by changing the server_version to server_version_num, as this is a number and the TDE information is not present. This also simplifies the comparison of the versions.