- Notifications
You must be signed in to change notification settings - Fork1k
chore: Enforce workspace proxy unique name case insensitive#7202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.
Uh oh!
There was an error while loading.Please reload this page.
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,8 @@ | ||||||
BEGIN; | ||||||
DROP INDEX IF EXISTS workspace_proxies_lower_name_idx; | ||||||
-- Enforces no active proxies have the same name. | ||||||
CREATE UNIQUE INDEX ON workspace_proxies (name) WHERE deleted = FALSE; | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. shouldn't it be There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Nop, I copied the previous migration that added the index: coder/coderd/database/migrations/000114_workspace_proxy.up.sql Lines 20 to 21 in9e218f7
Forgot to use a btree there, so kept it as it was for the Down. | ||||||
COMMIT; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
BEGIN; | ||
-- No one is using this feature yet as of writing this migration, so this is | ||
-- fine. Just delete all workspace proxies to prevent the new index from having | ||
-- conflicts. | ||
DELETE FROM workspace_proxies; | ||
DROP INDEX IF EXISTS workspace_proxies_name_idx; | ||
CREATE UNIQUE INDEX workspace_proxies_lower_name_idx ON workspace_proxies USING btree (lower(name)) WHERE deleted = FALSE; | ||
COMMIT; |
Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.
Uh oh!
There was an error while loading.Please reload this page.