- Notifications
You must be signed in to change notification settings - Fork1k
chore: Enforce workspace proxy unique name case insensitive#7202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| DROP INDEX IF EXISTS workspace_proxies_lower_name_idx; | ||
| -- Enforces no active proxies have the same name. | ||
| CREATE UNIQUE INDEX ON workspace_proxies (name) WHERE deleted = FALSE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
shouldn't it beCREATE UNIQUE INDEX workspace_proxies_name_idx ON workspace_proxies USING btree (name) WHERE deleted = FALSE;?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nop, I copied the previous migration that added the index:
coder/coderd/database/migrations/000114_workspace_proxy.up.sql
Lines 20 to 21 in9e218f7
| -- Enforces no active proxies have the same name. | |
| CREATEUNIQUE INDEXON workspace_proxies (name)WHERE deleted= FALSE; |
Forgot to use a btree there, so kept it as it was for the Down.
I need the PR#7176 merged to write the unit tests 😢. It has the http endpoints to test.