Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(site): Close WS and SE connections when they are not used#7187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 4 commits intomainfrombq/fix-web-socket-connections
Apr 20, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

About the fix:

  • Change the watch services to return a function closing the connection
  • Refactor the promises to regular functions where they can do actions when receiving a message, or error or when it is done
  • Transition the watching state to something else using a callback event

⚠️ This touches some important parts of the UI so I would love some extra QA:

  • Workspace page - Check if the statuses are being updated automatically and the startup logs as well
  • Template version logs - Check if the logs are being displayed correctly
  • Template version editor - Check if the logs are showing correctly

Fix#6782

@BrunoQuaresmaBrunoQuaresma self-assigned thisApr 18, 2023
Copy link
Member

@Kira-PilotKira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks like its working to me!

@BrunoQuaresmaBrunoQuaresmaenabled auto-merge (squash)April 20, 2023 15:52
@BrunoQuaresmaBrunoQuaresma merged commite90a076 intomainApr 20, 2023
@BrunoQuaresmaBrunoQuaresma deleted the bq/fix-web-socket-connections branchApril 20, 2023 17:01
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 20, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@Kira-PilotKira-PilotKira-Pilot approved these changes

@kylecarbskylecarbsAwaiting requested review from kylecarbs

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Websocket connections are not closing when users navigating away from the page

2 participants

@BrunoQuaresma@Kira-Pilot

[8]ページ先頭

©2009-2025 Movatter.jp