- Notifications
You must be signed in to change notification settings - Fork1.1k
feat(UI): add workspace restart button#7137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…to w-restart-btn/kira-pilot
| workspace={workspace} | ||
| handleStart={()=>workspaceSend({type:"START"})} | ||
| handleStop={()=>workspaceSend({type:"STOP"})} | ||
| handleRestart={()=>workspaceSend({type:"START"})} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Arestart is essentially just astart, so I simplified here instead of building out a new state in our workspace machine.
There might be edge cases that require astop before astart, but we do the exact same thing (start without stopping first) forupdate and we haven't had any complaints about that feature, so I figure we start simple.
BrunoQuaresma left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
This PR replaces#7070 andresolves#6241 (but not#5800). We've decided to implement the restart functionality entirely on the FE after realizing the previous PR would require Provisioner changes, and this small feature does not warrant such a change at this point in time.
