Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

ci: skip ts or go tests based on changed files#7134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
matifali merged 15 commits intomainfromdean/skip-tests-fe-be
Jun 9, 2023

Conversation

deansheather
Copy link
Member

@deansheatherdeansheather commentedApr 14, 2023•
edited
Loading

Closes#7147

Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you!

@matifalimatifali self-requested a reviewApril 26, 2023 13:20
@deansheatherdeansheather marked this pull request as draftApril 26, 2023 13:22
@github-actions
Copy link

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelMay 4, 2023
@matifali
Copy link
Member

unstale.@deansheather

@github-actionsgithub-actionsbot removed the staleThis issue is like stale bread. labelMay 5, 2023
@github-actions
Copy link

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelMay 12, 2023
@matifalimatifali removed the staleThis issue is like stale bread. labelMay 12, 2023
@github-actions
Copy link

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelMay 20, 2023
@johnstcnjohnstcn reopened thisMay 23, 2023
@johnstcnjohnstcn removed the staleThis issue is like stale bread. labelMay 23, 2023
@kylecarbskylecarbs removed their request for reviewMay 24, 2023 15:46
@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelJun 1, 2023
@matifalimatifali reopened thisJun 5, 2023
@github-actionsgithub-actionsbot removed the staleThis issue is like stale bread. labelJun 6, 2023
@matifalimatifali changed the titlechore: skip ts or go tests based on files changedci: skip ts or go tests based on files changedJun 9, 2023
@matifalimatifali changed the titleci: skip ts or go tests based on files changedci: skip ts or go tests based on changed filesJun 9, 2023
@matifalimatifali self-assigned thisJun 9, 2023
@matifalimatifali marked this pull request as ready for reviewJune 9, 2023 17:12
@matifalimatifali requested a review fromammarioJune 9, 2023 17:12
Copy link
Member

@ammarioammario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I tried this once before, but it caused issues because the required status checks would never pass on e.g. a docs PR.

We could get around that by checking the changed files in therun body, andexit 0 early if no relevant files changed.

In an ideal world, test caching would make all of this a non-issue.

@matifali
Copy link
Member

I discussed this with@deansheather and he said that he will change the settings to make the new required job as required. So it will work in that case.

Copy link
Member

@ammarioammario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Clever clever dean

matifali reacted with thumbs up emoji
@matifali
Copy link
Member

matifali commentedJun 9, 2023•
edited
Loading

I added a new filterci that will allow to run all tests if we make changes to.github directory.

@matifalimatifali merged commit634e146 intomainJun 9, 2023
@matifalimatifali deleted the dean/skip-tests-fe-be branchJune 9, 2023 23:53
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 9, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

@ammarioammarioammario approved these changes

@matifalimatifalimatifali approved these changes

@mafredrimafredriAwaiting requested review from mafredri

+1 more reviewer

@coadlercoadlercoadler approved these changes

Reviewers whose approvals may not affect merge requirements

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

do not run go/ts tests for PRs that only target docs

7 participants

@deansheather@matifali@mafredri@BrunoQuaresma@coadler@ammario@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp