Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

refactor(site): Refactor workspace actions#7124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 8 commits intomainfrombq/refactor-workspace-header
Apr 14, 2023

Conversation

@BrunoQuaresma
Copy link
Contributor

@BrunoQuaresmaBrunoQuaresma requested a review froma teamApril 13, 2023 16:42
@BrunoQuaresmaBrunoQuaresma self-assigned thisApr 13, 2023
@BrunoQuaresmaBrunoQuaresma requested review fromKira-Pilot and removed request fora teamApril 13, 2023 16:42
@matifali
Copy link
Member

Why to show both start, and stop when only 1 of them can be clicked at a time? What about using the same position and change it to start or stop depending on the workspace condition.

Start if workspace is stopped
Stop if workspace is starting
Disable if state is starting or deleting

@BrunoQuaresma
Copy link
ContributorAuthor

@matifali in this case is showing both because it is in the failed state. More info:#6468

matifali reacted with eyes emoji

Copy link
Member

@Kira-PilotKira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice and clean!

@BrunoQuaresmaBrunoQuaresmaenabled auto-merge (squash)April 14, 2023 14:33
@BrunoQuaresmaBrunoQuaresma merged commit7bbbb91 intomainApr 14, 2023
@BrunoQuaresmaBrunoQuaresma deleted the bq/refactor-workspace-header branchApril 14, 2023 15:28
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 14, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@Kira-PilotKira-PilotKira-Pilot approved these changes

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: clicking delete workspace does not respond

4 participants

@BrunoQuaresma@matifali@Kira-Pilot
[8]ページ先頭
©2009-2025 Movatter.jp