- Notifications
You must be signed in to change notification settings - Fork1.1k
chore: Rbac errors should be returned, and not hidden behind 404#7122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
SqlErrNoRows was hiding actual errors
johnstcn approved these changesApr 13, 2023
| // nolint:gocritic // GetWorkspaceAppsByAgentIDs is a system function. | ||
| apps,err:=api.Database.GetWorkspaceAppsByAgentIDs(ctx,resourceAgentIDs) | ||
| apps,err:=api.Database.GetWorkspaceAppsByAgentIDs(dbauthz.AsSystemRestricted(ctx),resourceAgentIDs) |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ooops, I missed this
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The sql.ErrNoRows hid it
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
sql.ErrNoRowswas hiding actual errors. This makes dbauthz return actual unauthorized errors, and the api just needs to check bothsql.ErrNoRowsanddbauthz.IsUnauthorizedto return a 404.Fixes:#6774