Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add advanced schedule settings#7061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
rodrimaia merged 4 commits intomainfromfeat_add_autostop_setting
Apr 12, 2023
Merged

Conversation

rodrimaia
Copy link
Contributor

@rodrimaiarodrimaia commentedApr 10, 2023•
edited by deansheather
Loading

image

Closes#6047
Closes#6497

@rodrimaiarodrimaia self-assigned thisApr 10, 2023
@rodrimaiarodrimaia changed the titleddfeat: add advanced schedule settingsfeat: add advanced schedule settingsApr 10, 2023
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Copy link
Member

@deansheatherdeansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, but can we changeauto-start =>autostart andauto-stop toautostop? Sorry if my original diagrams were incorrect but this is what we've settled on now

@rodrimaiarodrimaiaforce-pushed thefeat_add_autostop_setting branch frombd21474 tof5916cfCompareApril 11, 2023 20:31
@BrunoQuaresma
Copy link
Collaborator

@rodrimaia is just a minor thing. The secondary text of the new checkbox does not match the current style. You can see
an existing one with a smaller secondary text and a more gray color.

Screen Shot 2023-04-12 at 10 12 13

@rodrimaia
Copy link
ContributorAuthor

@rodrimaia is just a minor thing. The secondary text of the new checkbox does not match the current style. You can see an existing one with a smaller secondary text and a more gray color.

Screen Shot 2023-04-12 at 10 12 13

Fixed! thank you for noticing, Bruno! :)

@rodrimaiarodrimaiaenabled auto-merge (squash)April 12, 2023 17:44
@rodrimaiarodrimaia merged commitd1d459c intomainApr 12, 2023
@rodrimaiarodrimaia deleted the feat_add_autostop_setting branchApril 12, 2023 17:47
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 12, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@deansheatherdeansheatherdeansheather left review comments

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

Assignees

@rodrimaiarodrimaia

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

scheduling: Add a toggle in template settings to disable user-controlled shutdown behavior scheduling: advanced scheduling controls

3 participants

@rodrimaia@BrunoQuaresma@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp