NotificationsYou must be signed in to change notification settings
Fork1k
Star11.2k

test: Increase test coverage on auditable resources#7038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Emyrk merged 5 commits intomainfromstevenmasley/more_audit_tests

Apr 6, 2023

Merged

test: Increase test coverage on auditable resources#7038

Emyrk merged 5 commits intomainfromstevenmasley/more_audit_tests

Apr 6, 2023

Conversation

Copy link

Member

Emyrk commentedApr 6, 2023•
edited
Loading

When adding a new audit resource, we also need to add it to the
function switch statements. This is a likely mistake, now a unit
test will check this for you

Missing a type

table_internal_test.go:85: ResourceTarget switch statement is missing type "github.com/coder/coder/coderd/database.TemplateVersion". Include it in the switch case block

Extra type

table_internal_test.go:85: ResourceTarget switch statement has unexpected type "github.com/coder/coder/coderd/database.TemplateACL". Remove it from the switch case block

Emyrk added2 commits

April 6, 2023 13:09

test: Increase test coverage on auditable resources

aeb4603

When adding a new audit resource, we also need to add it to thefunction switch statements. This is a likely mistake, now a unittest will check this for you

Add comments

e1e8666