This is an idea I had.

The problem is that the CoderdAPI struct callsWait() on a waitgroup for all websockets to close before theClose() method returns. TheClose() method callscancel on the parent context, but this context is not actually controlling the lifecycle of the individual request for a given websocket.

SoClose()does not tell a websocket to end. It was achieving this because the parent context is tied to*wsconncache.Cache which kills the tailnet connections from the parent context.

To make this work more directly, I implementedActiveWebsockets. This struct takes the parent context. When you callAccept on this struct, it launches a go routine that will force close the websocket if the parent context is cancelled. This all happens when you callClose() on theActiveWebsocket struct.

This also means we can pass this struct in places likeWithWebsocketSupport:

Right now we just duplicate thesync.WaitGroup logic and return aWait() which is just kinda annoying.

This isn't 100% better, but it does handle the tracking:

Thoughts?