Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(site): Prompting user for missing variables#7002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 3 commits intomainfrombq/fix-immutable-parameters
Apr 4, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

requiredParameters.push(p)
return
}
})
Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@mtojek@bpmct is this logic correct? I must admit that asking or not for missing parameters is pretty challenging to understand for me 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Let me try it locally...

BrunoQuaresma reacted with thumbs up emoji
@BrunoQuaresmaBrunoQuaresmaenabled auto-merge (squash)April 4, 2023 13:06
@BrunoQuaresmaBrunoQuaresma merged commit46f42ea intomainApr 4, 2023
@BrunoQuaresmaBrunoQuaresma deleted the bq/fix-immutable-parameters branchApril 4, 2023 13:15
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 4, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mtojekmtojekmtojek approved these changes

@bpmctbpmctAwaiting requested review from bpmct

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rich parameters: not prompting me for missing variables
2 participants
@BrunoQuaresma@mtojek

[8]ページ先頭

©2009-2025 Movatter.jp