Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: update example templates to usedisplay_name#7001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bpmct merged 17 commits intocoder:mainfrommatifali:update-example-templates
Apr 12, 2023
Merged

chore: update example templates to usedisplay_name#7001

bpmct merged 17 commits intocoder:mainfrommatifali:update-example-templates
Apr 12, 2023

Conversation

matifali
Copy link
Member

@matifalimatifali commentedApr 4, 2023•
edited
Loading

Thisresolves#6978
I validated all the templates withterraform validate

@matifalimatifali requested a review frombpmctApril 4, 2023 11:13
@matifalimatifali changed the titlechore: adddisplay_name to example templateschore: update example templates to usedisplay_nameApr 4, 2023
@matifalimatifali marked this pull request as ready for reviewApril 4, 2023 11:25
@matifalimatifali requested a review frommtojekApril 4, 2023 12:14
Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for PR! Most comments refer to usingdisplay_name as a description, and for that we have a separate property.

@matifalimatifali requested a review frommtojekApril 7, 2023 08:58
@matifali
Copy link
MemberAuthor

@mtojek I have updated as per suggestions and moved the longerdisplay_name fields todescription where applicable

Copy link
Member

@bpmctbpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you change all casing to title case?

e.g.

  • Docker Image ->Docker image
  • Home Volume Size ->Home volume size

matifali reacted with thumbs up emoji
matifaliand others added6 commitsApril 7, 2023 22:28
Co-authored-by: Ben Potter <me@bpmct.net>
Co-authored-by: Ben Potter <me@bpmct.net>
Co-authored-by: Ben Potter <me@bpmct.net>
Co-authored-by: Ben Potter <me@bpmct.net>
Co-authored-by: Ben Potter <me@bpmct.net>
Co-authored-by: Ben Potter <me@bpmct.net>
@bpmctbpmctenabled auto-merge (squash)April 7, 2023 19:30
@bpmctbpmctdisabled auto-mergeApril 7, 2023 19:30
@matifalimatifali requested a review frombpmctApril 12, 2023 17:28
@bpmctbpmct merged commit114d4aa intocoder:mainApr 12, 2023
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 12, 2023
@matifalimatifali deleted the update-example-templates branchApril 14, 2023 11:33
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@mtojekmtojekmtojek approved these changes

@bpmctbpmctbpmct approved these changes

Assignees

@matifalimatifali

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

update examples to use display_name

3 participants

@matifali@mtojek@bpmct
[8]ページ先頭
©2009-2025 Movatter.jp