Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: addcoder stat command#6938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
ammario wants to merge2 commits intomainfromeasy-metadata
Closed

feat: addcoder stat command#6938

ammario wants to merge2 commits intomainfromeasy-metadata

Conversation

ammario
Copy link
Member

@ammarioammario commentedMar 31, 2023
edited by bpmct
Loading

closes#7076

@mafredri
Copy link
Member

Suggestion: Should we call thisstats orinfo so as to not be confused withhttps://en.wikipedia.org/wiki/Stat_(system_call)?

@ammario
Copy link
MemberAuthor

@mafredri thestat name (by itself) is not great. I was trying to be consistent withdstat,vmstat,sysstat and friends. We could follow in the footsteps ofdstat and make itcstat? I worry thatinfo orstats could be confused for a command that gets the stats of a workspace. I'm also hesitant to use a long name because this invocation will be repeated frequently in templates.

@mafredri
Copy link
Member

@ammario fair. Given that, I don't really have any great suggestions or alternatives. Calling itsysstat would be quite good, but wouldn't want it to be confused with the actual suite of tools. Likewisecstat is good but doesn't inherently mean much to the casual user. I guess that leavesstat orcstat as options, or if you manage to come up with a better one 😄

@ammario
Copy link
MemberAuthor

@mafredri sysstat is my favorite as well. Might just steal the name.

mafredri reacted with heart emoji

@github-actions
Copy link

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelApr 19, 2023
@ammario
Copy link
MemberAuthor

I'm not going to have time to work on this in the next couple of weeks.@bpmct may assist in finding someone new.

@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 19, 2023
}

cpuAcct := func() (int64, error) {
path := fmt.Sprintf("/sys/fs/cgroup/cpu,cpuacct/%s/cpuacct.usage", groupDir)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@bpmct go pkg doesn't handle this on its own, and we need to specify the path of the cgroup, which is kernel/release dependent.

@github-actionsgithub-actionsbot deleted the easy-metadata branchOctober 1, 2023 00:11
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@matifalimatifalimatifali left review comments

Assignees

@ammarioammario

Labels
staleThis issue is like stale bread.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

agent metadata: addcoder stat to identify Kubernetes cgroup usage
3 participants
@ammario@mafredri@matifali

[8]ページ先頭

©2009-2025 Movatter.jp