- Notifications
You must be signed in to change notification settings - Fork928
feat(coderd): add DERP healthcheck#6936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
| "tailscale.com/tailcfg" | ||
| ) | ||
| type Report struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ideally there's an overall "Pass" or "Fail" grade, as well as a "Pass" or "Fail" for each of the sub-reports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I thought about that but at least for DERP pass/fail felt more like a spectrum. You could have a derp server that could exchange messages but was listed as STUN but STUN wasn't working, etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Eh maybe "Fail" could just mean anything failed or is degraded.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| if strings.Contains(msg, "We'll use WebSockets on the next connection attempt") { | ||
| r.UsesWebsocket = true | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nice touch
Updates:#6728