Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Implement experiment gated CRUD for workspace proxies#6928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 26 commits intomainfromstevenmasley/moon_crud
Apr 4, 2023

Conversation

Emyrk
Copy link
Member

Workspace proxies currently do nothing, this is just the DB crud side

Fixes:#6906

Future work

More fields to be added.

@EmyrkEmyrk marked this pull request as ready for reviewMarch 31, 2023 16:27
@EmyrkEmyrk requested a review fromdeansheatherApril 3, 2023 15:51
Copy link
Member

@deansheatherdeansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks good but I don't understand why moons are org-scoped when they're a thing done at the deployment level. Only site owners should be able to add moons and they should be deployment-scoped and work for any workspace in any org.

@EmyrkEmyrk merged commitb4afbe7 intomainApr 4, 2023
@EmyrkEmyrk deleted the stevenmasley/moon_crud branchApril 4, 2023 20:07
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 4, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@EmyrkEmyrk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Moon CRUD

2 participants

@Emyrk@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp