Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: rich parameters: introduce display_name#6919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mtojek merged 26 commits intocoder:mainfrommtojek:6852-display-name
Apr 3, 2023

Conversation

mtojek
Copy link
Member

@mtojekmtojek commentedMar 31, 2023•
edited
Loading

Fixes:#6852

This PR enables an extra coder parameter property,display_name. This property will be used to display the human-readable parameter name.

data"coder_parameter""random_string" {name="Optional random string"display_name="Very random string"icon="/icon/aws.png"description="This string is optional"mutable=truedefault=""}data"coder_parameter""project_id" {name="project_id"display_name="My Project ID"icon="/icon/azure.png"description="This is the Project ID."default="12345"validation {regex="^[a-z0-9]+$"error="I'm sorry, my friend"  }}

Screenshot 2023-04-03 at 11 45 51

Screenshot 2023-04-03 at 11 45 33

Screenshot 2023-04-03 at 11 48 58

Changes:

  • Adjust backend to processdisplay_name
  • CLI
  • Site UI

@mtojekmtojek self-assigned thisMar 31, 2023
@mtojekmtojek marked this pull request as ready for reviewApril 3, 2023 10:05
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@mtojekmtojek merged commit633dfbd intocoder:mainApr 3, 2023
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 3, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

@bpmctbpmctAwaiting requested review from bpmct

Assignees

@mtojekmtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cannot pre-fill template parameter values with param name
3 participants
@mtojek@BrunoQuaresma@Kira-Pilot
[8]ページ先頭
©2009-2025 Movatter.jp