- Notifications
You must be signed in to change notification settings - Fork928
fix(agent): Close stdin and stdout separately to fix pty output loss#6862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
010f111 to40377beCompare40377be to197bedcCompare| // This might be our implementation, or ConPTY itself. | ||
| // It's difficult to find extensive tests for it, so | ||
| // it seems like it could be either. | ||
| t.Skip("ConPTY appears to be inconsistent on Windows.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This might be risky (flakey CI), but maybe we should see if it's a problem on Windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Agreed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM stamp, but I didn't test it.
Fixes#6656
Closes#6840