Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: reduce docker examples#6849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bpmct merged 6 commits intomainfromreduce-docker-examples
Apr 12, 2023
Merged

chore: reduce docker examples#6849

bpmct merged 6 commits intomainfromreduce-docker-examples
Apr 12, 2023

Conversation

bpmct
Copy link
Member

fixes#4651

Copy link
Member

@kylecarbskylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Love this!

@bpmctbpmctenabled auto-merge (squash)March 28, 2023 15:07
@github-actions
Copy link

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelApr 5, 2023
@matifali
Copy link
Member

the stale bot is being spammy.

@github-actionsgithub-actionsbot removed the staleThis issue is like stale bread. labelApr 6, 2023
@matifali
Copy link
Member

Do you have any plans to merge this sooner? I am working on#7001 and its better if this merges before that@bpmct

@matifali
Copy link
Member

matifali commentedApr 7, 2023•
edited
Loading

Let's keep only these 2.

  1. docker-with-dotfiles

    This containsdocker

  2. docker-image-builds

    This demonstrates that Coder can build the images too.

Thoughts@bpmct ?

@bpmct
Copy link
MemberAuthor

Sorry I missed these comments@matifali. I'd rather stick to one example for now.

matifali reacted with thumbs up emoji

@matifali
Copy link
Member

Sounds fine.

@matifali
Copy link
Member

matifali commentedApr 11, 2023•
edited
Loading

@bpmct
You need to update the test too,

tarData,err:=examples.Archive("docker-image-builds")

@bpmctbpmct merged commitaf24aea intomainApr 12, 2023
@bpmctbpmct deleted the reduce-docker-examples branchApril 12, 2023 16:26
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 12, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@kylecarbskylecarbskylecarbs approved these changes

+1 more reviewer

@sharkymarksharkymarksharkymark approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bpmctbpmct

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

There are 4 example templates that basically do the same thing - confusing - remove one

4 participants

@bpmct@matifali@sharkymark@kylecarbs
[8]ページ先頭
©2009-2025 Movatter.jp