Mar 27, 2023 · Mar 25, 2023 · Mar 27, 2023 · Mar 27, 2023
diff --git a/cli/ssh.go b/cli/ssh.go
 if xerrors.Is(err, context.Canceled) {
 return cliui.Canceled
 }
 if xerrors.Is(err, cliui.AgentStartError) {
 return xerrors.New("Agent startup script exited with non-zero status, use --no-wait to login anyway.")
 if!xerrors.Is(err, cliui.AgentStartError) {
 return xerrors.Errorf("await agent: %w", err)
 }
 return xerrors.Errorf("await agent: %w", err)

 // We don't want to fail on a startup script error because it's
 // natural that the user will want to fix the script and try again.
 // We don't print the error because cliui.Agent does that for us.
 }

 conn, err := client.DialWorkspaceAgent(ctx, workspaceAgent.ID, &codersdk.DialWorkspaceAgentOptions{})
Original file line number	Diff line number	Diff line change
Expand Up		@@ -82,10 +82,13 @@ func (r RootCmd) ssh() clibase.Cmd {
		if xerrors.Is(err, context.Canceled) {
		return cliui.Canceled
		}
		if xerrors.Is(err, cliui.AgentStartError) {
		return xerrors.New("Agent startup script exited with non-zero status, use --no-wait to login anyway.")
		if!xerrors.Is(err, cliui.AgentStartError) {
		return xerrors.Errorf("await agent: %w", err)
		}
		return xerrors.Errorf("await agent: %w", err)

		// We don't want to fail on a startup script error because it's
		// natural that the user will want to fix the script and try again.
		// We don't print the error because cliui.Agent does that for us.
Copy link Member mafredriMar 27, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. @ammario with this change, there'll be no indication for people SSH:ing in that there's a problem or that the workspace ran into an error (`--stdio`). The logs would only be visible by doing`ssh -v`. I guess one option would be to print this on the agent side, as part of MOTD. Copy link MemberAuthor ammarioMar 27, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. MOTD makes sense to me
		}

		conn, err := client.DialWorkspaceAgent(ctx, workspaceAgent.ID, &codersdk.DialWorkspaceAgentOptions{})
Expand Down