- Notifications
You must be signed in to change notification settings - Fork928
fix: permit SSH by default when startup script fails#6798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| // We don't want to fail on a startup script error because it's | ||
| // natural that the user will want to fix the script and try again. | ||
| // We don't print the error because cliui.Agent does that for us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@ammario with this change, there'll be no indication for people SSH:ing in that there's a problem or that the workspace ran into an error (--stdio).
The logs would only be visible by doingssh -v.
I guess one option would be to print this on the agent side, as part of MOTD.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
MOTD makes sense to me
No description provided.