Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(site): Ask for version name and if it is active when publishing a new version on editor#6756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 8 commits intomainfrombq/ask-template-version-name
Mar 27, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

Demo:

Screen.Recording.2023-03-23.at.16.07.57.mov

Fix#6169
Close#6124

@BrunoQuaresmaBrunoQuaresma requested a review froma teamMarch 23, 2023 19:11
@BrunoQuaresmaBrunoQuaresma self-assigned thisMar 23, 2023
@BrunoQuaresmaBrunoQuaresma requested review fromKira-Pilot and removed request fora teamMarch 23, 2023 19:11
@BrunoQuaresmaBrunoQuaresma requested a review froma teamMarch 24, 2023 14:24
@Kira-Pilot
Copy link
Member

This is a really cool feature - great job! Do we need any validation on the version name? I imagine we might get a conflict if we have two of the same name.

@BrunoQuaresma
Copy link
CollaboratorAuthor

This is a really cool feature - great job! Do we need any validation on the version name? I imagine we might get a conflict if we have two of the same name.

It is a good question. Let me try and see what happens.

@BrunoQuaresmaBrunoQuaresmaenabled auto-merge (squash)March 27, 2023 15:47
@BrunoQuaresmaBrunoQuaresma merged commitdd4e1f7 intomainMar 27, 2023
@BrunoQuaresmaBrunoQuaresma deleted the bq/ask-template-version-name branchMarch 27, 2023 17:26
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 27, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@Kira-PilotKira-PilotKira-Pilot approved these changes

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@BrunoQuaresma@Kira-Pilot
[8]ページ先頭
©2009-2025 Movatter.jp