- Notifications
You must be signed in to change notification settings - Fork928
fix(site): Fix CSP directives for monaco#6709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -326,7 +326,8 @@ func cspHeaders(next http.Handler) http.Handler { | |||
| CSPDirectiveScriptSrc: {"'self' https://cdn.jsdelivr.net"}, | |||
| CSPDirectiveStyleSrc: {"'self' 'unsafe-inline' https://cdn.jsdelivr.net"}, | |||
| // data: is used by monaco editor on FE for Syntax Highlight | |||
| CSPDirectiveFontSrc: {"'self' data:"}, | |||
| CSPDirectiveFontSrc: {"'self' https://cdn.jsdelivr.net data:"}, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
cc@Emyrk
@BrunoQuaresma we can't import external assets like this, because we're self-hosted customers might be airgapped.
BrunoQuaresmaMar 21, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, I'm aware of it. Since we are already doing it I added it as a quick fix. In the past, I tried to make Monaco editor work with local file but it didn't work. I will give it a try again during the week. If we are not able to get this working, we may need a plan.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ahh, I see! That's helpful context.
Customers will likely see this come up in security scans, becauseI believe users can host anything onjsdelivr, so an XSS attack becomes possible with this in product.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good to know about jsdeliver. We can match specific files, eg:
https://cdn.jsdelivr.net/the/file/we/wantThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I totally agree. I think would be very hard to track files individually.
Closes#6590