Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(coder): Add PATCH /templateversions/:templateversion endpoint#6698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 12 commits intomainfrombq/patch-template-version-name
Mar 23, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma commentedMar 21, 2023•
edited
Loading

Before adding tests, I would like to confirm I'm doing the right thing.

related to#6124

Copy link
Member

@ammarioammario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just minor comments.

@@ -76,6 +76,10 @@ type TemplateVersionVariable struct {
Sensitive bool `json:"sensitive"`
}

type PatchTemplateVersionRequest struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think that I asked this question on slack, but it wasmissed.

Why in the first place we need to modify the template name? Why using the randomly generated one is bad?

Copy link
CollaboratorAuthor

@BrunoQuaresmaBrunoQuaresmaMar 22, 2023•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think being able to add a custom name for the template version is way easier to identify and find it after IMO.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Not sure if we need this feature considering the fact that everywhere we keep using the randomly generated.@bpmct what do you think?

@mtojek
Copy link
Member

CI also complains about some unit tests.

@mtojek
Copy link
Member

As agreed with@BrunoQuaresma, I will take it over to complete.

@mtojekmtojek self-assigned thisMar 22, 2023
@mtojekmtojek marked this pull request as draftMarch 22, 2023 14:16
@mtojekmtojek marked this pull request as ready for reviewMarch 22, 2023 15:43
@mtojek
Copy link
Member

@BrunoQuaresma I'm done with improvements. Could you please take a look and 👍 or 👎 ?

@ammario
Copy link
Member

if it's good by@mtojek it's good by me — i don't have the bandwidth to review this morning

@ammarioammario removed their request for reviewMarch 23, 2023 15:34
@BrunoQuaresmaBrunoQuaresma merged commit8857971 intomainMar 23, 2023
@BrunoQuaresmaBrunoQuaresma deleted the bq/patch-template-version-name branchMarch 23, 2023 16:26
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 23, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mtojekmtojekmtojek left review comments

@ammarioammarioammario approved these changes

@kylecarbskylecarbsAwaiting requested review from kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@BrunoQuaresma@mtojek@ammario
[8]ページ先頭
©2009-2025 Movatter.jp