Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(site): Support list(string) rich parameter field#6653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 3 commits intomainfrombq/multi-string-field
Mar 17, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

Demo:

Screen.Recording.2023-03-17.at.14.29.36.mov

Close#6582

@BrunoQuaresmaBrunoQuaresma requested review frommtojek anda teamMarch 17, 2023 17:33
@BrunoQuaresmaBrunoQuaresma self-assigned thisMar 17, 2023
@BrunoQuaresmaBrunoQuaresma requested review fromKira-Pilot and removed request fora teamMarch 17, 2023 17:33
setParameterValue(value)
onChange(value)
} catch (e) {
console.error("Error on change of list(string) parameter", e)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Do we need to do anything else with error handling here or on line 165?

Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is something we control but in case it gets an error, I added a message to help a bit more.

@BrunoQuaresmaBrunoQuaresmaenabled auto-merge (squash)March 17, 2023 18:48
@BrunoQuaresmaBrunoQuaresma merged commitca067cf intomainMar 17, 2023
@BrunoQuaresmaBrunoQuaresma deleted the bq/multi-string-field branchMarch 17, 2023 18:53
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 17, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@Kira-PilotKira-PilotKira-Pilot approved these changes

@mtojekmtojekAwaiting requested review from mtojek

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rich parameters: support new type list(string)
2 participants
@BrunoQuaresma@Kira-Pilot

[8]ページ先頭

©2009-2025 Movatter.jp