Mar 17, 2023 · Mar 16, 2023 · Mar 16, 2023
diff --git a/site/src/api/api.test.ts b/site/src/api/api.test.ts
 import {
  MockTemplate,
  MockTemplateVersionParameter1,
  MockTemplateVersionParameter2,
  MockWorkspace,
  MockWorkspaceBuild,
 } from "testHelpers/entities"
    it("fails when having missing parameters", async () => {
      jest
        .spyOn(api, "postWorkspaceBuild")
        .mockResolvedValueOnce(MockWorkspaceBuild)
      jest.spyOn(api, "getTemplate").mockResolvedValueOnce(MockTemplate)
      jest.spyOn(api, "getWorkspaceBuildParameters").mockResolvedValueOnce([])
        .mockResolvedValue(MockWorkspaceBuild)
      jest.spyOn(api, "getTemplate").mockResolvedValue(MockTemplate)
      jest.spyOn(api, "getWorkspaceBuildParameters").mockResolvedValue([])
      jest
        .spyOn(api, "getTemplateVersionRichParameters")
        .mockResolvedValueOnce([MockTemplateVersionParameter1])
        .mockResolvedValue([
          MockTemplateVersionParameter1,
          { ...MockTemplateVersionParameter2, mutable: false },
        ])

      let error = new Error()
      try {
        await api.updateWorkspace(MockWorkspace)
      } catch (e) {
        error = e as Error
      }

      await expect(api.updateWorkspace(MockWorkspace)).rejects.toThrow(
        api.MissingBuildParameters,
      )
      expect(error).toBeInstanceOf(api.MissingBuildParameters)
      // Verify if the correct missing parameters are being passed
      // It should not require immutable parameters
      expect((error as api.MissingBuildParameters).parameters).toEqual([
        MockTemplateVersionParameter1,
      ])
    })
  })
 })
diff --git a/site/src/api/api.ts b/site/src/api/api.ts
      continue
    }

    // If there is no value andit is required, add it to the list of missing parameters
    if (parameter.required) {
    // If there is no value,it is required and can be changed, add it to the list of missing parameters
    if (parameter.required && parameter.mutable) {
      missingParameters.push(parameter)
    }
  }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -2,6 +2,7 @@ import axios from "axios"
		import {
		MockTemplate,
		MockTemplateVersionParameter1,
		MockTemplateVersionParameter2,
		MockWorkspace,
		MockWorkspaceBuild,
		} from "testHelpers/entities"
Expand DownExpand Up		@@ -178,16 +179,29 @@ describe("api.ts", () => {
		it("fails when having missing parameters", async () => {
		jest
		.spyOn(api, "postWorkspaceBuild")
		.mockResolvedValueOnce(MockWorkspaceBuild)
		jest.spyOn(api, "getTemplate").mockResolvedValueOnce(MockTemplate)
		jest.spyOn(api, "getWorkspaceBuildParameters").mockResolvedValueOnce([])
		.mockResolvedValue(MockWorkspaceBuild)
		jest.spyOn(api, "getTemplate").mockResolvedValue(MockTemplate)
		jest.spyOn(api, "getWorkspaceBuildParameters").mockResolvedValue([])
		jest
		.spyOn(api, "getTemplateVersionRichParameters")
		.mockResolvedValueOnce([MockTemplateVersionParameter1])
		.mockResolvedValue([
		MockTemplateVersionParameter1,
		{ ...MockTemplateVersionParameter2, mutable: false },
		])

		let error = new Error()
		try {
		await api.updateWorkspace(MockWorkspace)
		} catch (e) {
		error = e as Error
		}

		await expect(api.updateWorkspace(MockWorkspace)).rejects.toThrow(
		api.MissingBuildParameters,
		)
		expect(error).toBeInstanceOf(api.MissingBuildParameters)
		// Verify if the correct missing parameters are being passed
		// It should not require immutable parameters
		expect((error as api.MissingBuildParameters).parameters).toEqual([
		MockTemplateVersionParameter1,
		])
		})
		})
		})
Original file line number	Diff line number	Diff line change
Expand Up		@@ -987,8 +987,8 @@ const updateBuildParameters = (
		continue
		}

		// If there is no value andit is required, add it to the list of missing parameters
		if (parameter.required) {
		// If there is no value,it is required and can be changed, add it to the list of missing parameters
		if (parameter.required && parameter.mutable) {
		missingParameters.push(parameter)
		}
		}
Expand Down