Mar 14, 2023 · Mar 14, 2023 · Mar 14, 2023 · Mar 14, 2023 · Mar 14, 2023 · Mar 14, 2023
diff --git a/coderd/coderd.go b/coderd/coderd.go
 if options.AgentInactiveDisconnectTimeout == 0 {
 // Multiply the update by two to allow for some lag-time.
 options.AgentInactiveDisconnectTimeout = options.AgentConnectionUpdateFrequency * 2
 // Set a minimum timeout to avoid disconnecting too soon.
 if options.AgentInactiveDisconnectTimeout < 2*time.Second {
 options.AgentInactiveDisconnectTimeout = 2 * time.Second
 }
 }
 if options.AgentStatsRefreshInterval == 0 {
 options.AgentStatsRefreshInterval = 5 * time.Minute
diff --git a/coderd/workspaceagents.go b/coderd/workspaceagents.go

 // We use a custom heartbeat routine here instead of `httpapi.Heartbeat`
 // because we want to log the agent's last ping time.
 varlastPing time.Time
 lastPing:=time.Now() // Since the agent initiated the request, assume it's alive.
 var pingMu sync.Mutex
 go pprof.Do(ctx, pprof.Labels("agent", workspaceAgent.ID.String()), func(ctx context.Context) {
 // TODO(mafredri): Is this too frequent? Use separate ping disconnect timeout?
diff --git a/scaletest/reconnectingpty/run_test.go b/scaletest/reconnectingpty/run_test.go

 func Test_Runner(t *testing.T) {
 t.Parallel()
 t.Skip("https://github.com/coder/coder/issues/6598")

 t.Run("OK", func(t *testing.T) {
 t.Parallel()
Original file line number	Diff line number	Diff line change
Expand Up		@@ -175,6 +175,10 @@ func New(options Options) API {
		if options.AgentInactiveDisconnectTimeout == 0 {
		// Multiply the update by two to allow for some lag-time.
		options.AgentInactiveDisconnectTimeout = options.AgentConnectionUpdateFrequency * 2
		// Set a minimum timeout to avoid disconnecting too soon.
		if options.AgentInactiveDisconnectTimeout < 2*time.Second {
Copy link Member mtojekMar 14, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. 2time.Second Interesting, doesn't`make fmt` complain about it? Copy link MemberAuthor mafredriMar 14, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. This is actually fmt's handiwork. It groups operands when there are multiple operators. Copy link Member mtojek*Mar 14, 2023 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. TIL!
		options.AgentInactiveDisconnectTimeout = 2 * time.Second
		}
		}
		if options.AgentStatsRefreshInterval == 0 {
		options.AgentStatsRefreshInterval = 5 * time.Minute
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -615,7 +615,7 @@ func (api API) workspaceAgentCoordinate(rw http.ResponseWriter, r http.Request

		// We use a custom heartbeat routine here instead of `httpapi.Heartbeat`
		// because we want to log the agent's last ping time.
		varlastPing time.Time
		lastPing:=time.Now() // Since the agent initiated the request, assume it's alive.
		var pingMu sync.Mutex
		go pprof.Do(ctx, pprof.Labels("agent", workspaceAgent.ID.String()), func(ctx context.Context) {
		// TODO(mafredri): Is this too frequent? Use separate ping disconnect timeout?
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -23,7 +23,6 @@ import (

		func Test_Runner(t *testing.T) {
		t.Parallel()
		t.Skip("https://github.com/coder/coder/issues/6598")

		t.Run("OK", func(t *testing.T) {
		t.Parallel()
Expand Down