- Notifications
You must be signed in to change notification settings - Fork928
fix(coderd): Ensure agent disconnect happens after timeout#6600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -175,6 +175,10 @@ func New(options *Options) *API { | |||
| if options.AgentInactiveDisconnectTimeout == 0 { | |||
| // Multiply the update by two to allow for some lag-time. | |||
| options.AgentInactiveDisconnectTimeout = options.AgentConnectionUpdateFrequency * 2 | |||
| // Set a minimum timeout to avoid disconnecting too soon. | |||
| if options.AgentInactiveDisconnectTimeout < 2*time.Second { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
2*time.Second
Interesting, doesn'tmake fmt complain about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is actually fmt's handiwork. It groups operands when there are multiple operators.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
TIL!
Fixes#6598