NotificationsYou must be signed in to change notification settings
Fork1.1k
Star11.7k

feat(site): Ask for parameter values when update a workspace#6586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

BrunoQuaresma merged 10 commits intomainfrombq/aks-missing-parameters-on-update

Mar 14, 2023

Merged

feat(site): Ask for parameter values when update a workspace#6586

BrunoQuaresma merged 10 commits intomainfrombq/aks-missing-parameters-on-update

Mar 14, 2023

Conversation

Copy link

Contributor

BrunoQuaresma commentedMar 13, 2023

Demo:

Screen.Recording.2023-03-13.at.14.51.10.mov

Closes#6100

BrunoQuaresma added8 commits

March 8, 2023 16:35

wip

3085418

Bind dialog

0998ae3

Merge branch 'main' into bq/aks-missing-parameters-on-update

84fd4a7

Add basic flow for missing parameters on update

ba975a9

Finish design

022e400

Merge branch 'main' into bq/aks-missing-parameters-on-update

731d179

Do not handle immutable parameters

5ff98ce

Update a few things

60bf64f

BrunoQuaresma requested review froma team andmtojek

March 13, 2023 17:55

BrunoQuaresma self-assigned this

Mar 13, 2023

BrunoQuaresma requested review fromcode-asher and removed request fora team

March 13, 2023 17:55

mtojek approved these changes

Mar 14, 2023

View reviewed changes

Copy link

Member

mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Reviewing your PRs always brings educational value to you. Thanks!

I left one nitpick and raised one question, but otherwise it's 👍 .

site/src/pages/WorkspacePage/UpdateBuildParametersDialog.tsx OutdatedShow resolvedHide resolved

site/src/util/richParameters.ts OutdatedShow resolvedHide resolved

site/src/testHelpers/handlers.ts OutdatedShow resolvedHide resolved

Copy link

Member

mtojek commentedMar 14, 2023

Oh, CI complained about:

FAIL test src/pages/WorkspacePage/WorkspacePage.test.tsx (41.707 s)  ● WorkspacePage › after an update postWorkspaceBuild is called with the latest template active version id    expect(jest.fn()).toBeCalledWith(...expected)    Expected: "test-outdated-workspace", "test-template-version"    Number of calls: 0    Ignored nodes: comments, script, style

Run:https://github.com/coder/coder/actions/runs/4408015320/jobs/7722465954