Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add startup script logs to the ui#6558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kylecarbs merged 34 commits intomainfromstartuplogs
Mar 23, 2023
Merged

feat: add startup script logs to the ui#6558

kylecarbs merged 34 commits intomainfromstartuplogs
Mar 23, 2023

Conversation

kylecarbs
Copy link
Member

@kylecarbskylecarbs commentedMar 10, 2023•
edited
Loading

Courtesy of@code-asher

Todo

  • Purge old logs periodically
  • Fix storybook

@kylecarbskylecarbs self-assigned thisMar 10, 2023
Comment on lines 690 to 693
if flushLogsTimer != nil {
flushLogsTimer.Reset(100 * time.Millisecond)
return
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

why do we reset the timer here?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

debounce baby. i'll add a comment

@kylecarbskylecarbs marked this pull request as ready for reviewMarch 18, 2023 17:38
@kylecarbskylecarbsforce-pushed thestartuplogs branch 2 times, most recently froma559240 to144fd17CompareMarch 23, 2023 04:37
@kylecarbskylecarbs merged commitcb73754 intomainMar 23, 2023
@kylecarbskylecarbs deleted the startuplogs branchMarch 23, 2023 19:09
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 23, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@sreyasreyasreya approved these changes

Assignees

@kylecarbskylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@kylecarbs@sreya@code-asher
[8]ページ先頭
©2009-2025 Movatter.jp