- Notifications
You must be signed in to change notification settings - Fork927
fix: remove deprecation warnings when option unset#6532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| if opt.Value.String() == opt.Default { | ||
| continue | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could you add a field to bigcli types similar to what cobra had for.Changed()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah, I'm still working through the migration. I think it'd be cool to have a value source for each field, so we can show people on the deployment page how everything is being set.
Resolves#6531