- Notifications
You must be signed in to change notification settings - Fork1.2k
Conversation
mafredri approved these changesMar 8, 2023
| @@ -979,7 +978,7 @@ func (c *DeploymentValues) Options() clibase.OptionSet { | |||
| Env: "LOG_HUMAN", | |||
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
you may want to rebase on top of#6511
johnstcn approved these changesMar 8, 2023
MemberAuthor
kylecarbs commentedMar 8, 2023
@johnstcn thank you! |
MemberAuthor
kylecarbs commentedMar 8, 2023
@johnstcn it seems to merge properly, so we should be good 😎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seehttps://github.com/coder/coder/actions/runs/4365865438/jobs/7635236079