- Notifications
You must be signed in to change notification settings - Fork927
feat: convert rest of CLI to clibase#6491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
192 commits Select commitHold shift + click to select a range
0dbcd12
Build out basic command scaffold
ammario18d31bf
Fixup middleware
ammarioec8e626
Support global flags
ammarioe54d393
Make progress...
ammario518b51d
486 problems left
ammarioc9820fb
go mod tidy
ammario32a1759
330 problems left...
ammario5af1142
208 problems left...
ammario5613d3b
185 problems left...
ammariob713372
359 problems left...
ammario7884f32
354 problems left...
ammarioa58d15e
434 problems left...
ammarioc8c9e51
511 problems left...
ammario274c84d
Assorted changes
ammario6fb72b5
621 problems remaining...
ammarioeeb9500
576 problems remaining...
ammarioe8959cf
500 problems remaining...
ammario799ace7
425 problems remaining...
ammario25682f6
417 problems left...
ammario88a64fc
Merge remote-tracking branch 'origin/main' into clibase-all
ammarioc0a77cc
396 problems left...
ammario6757d66
330 problems left...
ammario6c0b64a
248 problems left...
ammariod028e1e
162 problems left...
ammarioa678576
102 problems left...
ammarioc4e8925
44 problems left...
ammario46f0339
0 (compilation) problems left...
ammariod242a84
Get stuck on git askpass
ammario0706c19
Merge remote-tracking branch 'origin/main' into clibase-all
ammario6757d84
deployment values
ammario113ad13
Merge remote-tracking branch 'origin/main' into clibase-all
ammario855e97d
Fix GitAskPass tests
ammario04977de
Fix Dotfiles tests
ammariod183ce3
Fix ResetPassword test
ammarioee6b65b
help wip
ammariod19cae5
chore: move over some of the clibase changes
ammarioa57639b
Port over some of clibase
ammarioa571e0c
Simplify Invoke calls
ammario2b02e65
grr fmt.Errorf
ammario2884aa6
fix: treat empty env as defaults (#6538)
ammario71f2c32
Reduce indirection in clibasetest.IO
ammarioc6621bb
Cancel context when command finishes
ammariobe7f957
oops typo
ammario2f99f87
Merge branch 'some-clibase' into clibase-all
ammarioaac0fc0
Merge remote-tracking branch 'origin/main' into clibase-all
ammariobfbd0f5
Test Help
ammario7d12d64
Regen golden files!
ammariod5228c3
Sanity-check command options
ammario6f3575e
Progress
ammario029bd27
Limit newlines!
ammario74e5819
identation
ammario42d8011
Fix schedule test
ammario781d700
Fix CreateAdminUser
ammario94823df
Pass Rename + SSH
ammarioc2fdc2c
Fix a bunch of server tests
ammarioaee0627
Agent tests pass!
ammariof1d9c22
fixup! Agent tests pass!
ammarioeca5625
Get in insecure reader
ammariobe8dcc8
Speed up SSH keygen
ammario2500af8
Fix all tests in ./cli
ammarioe776504
Enterprise cli tests pass
ammariod6adedf
Start working on clidocsgen
ammario4f21d52
Hmm
ammario1e5d223
docs v1
ammarioad810f6
docs skeleton done
ammario4f52669
It's done!
ammario303f0ab
fmt
ammario51c132e
fixup! fmt
ammario6c697f6
Remove remaining call to cobra
ammario7ab0710
Merge remote-tracking branch 'origin/main' into clibase-all
ammariofc4342b
fix clitest
ammario0b1ed6f
Fix server tests
ammariob759071
Upgrade slog
ammario412f054
go mod tidy
ammario466c3dc
Erase cobra from memory
ammariod3dab44
Pass linter
ammariobf93f2b
Pass lint/gen
ammariof5e2611
Improve error presentation
ammario64a28b8
config dir
ammario3292af9
Refine error printing some more
ammario039ef66
Fix flake
ammariodf1e20a
sed: simplify tty attaches
ammario746f27d
fix compilation bugs
ammarioe8d6a47
Improve error formatting
ammario9852f0b
Hmm testutil
ammario36212f7
Merge remote-tracking branch 'origin/main' into clibase-all
ammario1cd34ef
Minor code style
ammario8216640
fix lint
ammario6dc4578
fixup! fix lint
ammario97233c2
rng
ammario2065ddc
Get rid of suspect fastrand
ammariof9cd94e
Restore long timeout in Server/Postgres test
ammario8f0b0fa
Increase default command timeout
ammario65e9dc3
minor cleanup
ammario527e7ef
Windows?
ammario6ec84aa
WINDOWS
ammario95508bd
Big man on campus
ammario695b56d
WINDNDDODODODOOOOWWS
ammario980768b
fixup! WINDNDDODODODOOOOWWS
ammario452ffdf
fixup! WINDNDDODODODOOOOWWS
ammario371e34d
fixup! WINDNDDODODODOOOOWWS
ammario888292c
fixup! WINDNDDODODODOOOOWWS
ammariof5fcc2c
fixup! WINDNDDODODODOOOOWWS
ammario8e04d8b
fixup! WINDNDDODODODOOOOWWS
ammario1b6062b
fixup! WINDNDDODODODOOOOWWS
ammario71e5700
Merge remote-tracking branch 'origin/main' into clibase-all
ammario59a53b4
WIN WIN WIN DOWS
ammario2acc7f0
fixup! WIN WIN WIN DOWS
ammariofaa3515
Address review comments
ammario1b281af
Add "unknown command" error
ammario1cba181
Reject args to coder server
ammario1e29b7a
Update cli/cliui/log.go
ammarioba9443a
Start addressing mathias feedback
ammario981bf55
Hit a couple more problems
ammarioe7d7d8a
fix: slim
ammario8da9ed3
Update cli/cliui/log.go
ammarioe176250
Remove all redundant Name fields
ammario813a30e
Address more comments
ammariob74c576
Merge remote-tracking branch 'origin/main' into clibase-all
ammario17cdcfc
WIP debug Create
ammario9958d26
Merge remote-tracking branch 'origin/main' into clibase-all
ammario4f4c66c
Improve errors
ammarioff3b858
found it!
ammario1f7eef1
Fix descriptions in entcli
ammario79a66c5
Merge remote-tracking branch 'origin/main' into clibase-all
ammario2781b7c
type out CODER_ prefix
ammariodc60ac8
fix root usage
ammarioe21d488
Fix test hang
ammario4e6e434
Merge remote-tracking branch 'origin/main' into clibase-all
ammario22a6978
Fix goroutine link in cliui
ammariod4ae272
Show subcommands first in help
ammario7bf9b21
Fix wrapping in subcommands
ammario3611907
Call out global options in each command's help
ammarioed700b8
Address some more comments
ammario0671e00
SCALETEST
ammario7d03079
Improve error formatting
ammario218f57e
Improve error style even more!
ammarioc075ee2
Remove `coder ssh --shuffle`, amongst other improvements
ammarioc6e7689
docs: align markdown names
ammario4435212
docs: show full use line!
ammario79d4130
docs: don't show empty tables
ammariodcf5b50
fix lint
ammario03d8a19
Update golden files
ammarioe122a9c
Merge remote-tracking branch 'origin/main' into clibase-all
ammarioc72050b
Fix help whitespace issues
mafredric33954c
Sort flags
mafredria774c0e
Sort commands
mafredri3cb50b3
Run make gen and update-golden-files
mafredrie33da7a
Show shorthand flag first
mafredri1b81037
Run make gen and update-golden-files
mafredrie96d155
Fix prepare all after options
mafredri81c4543
Address review comments
ammario4338598
Merge remote-tracking branch 'origin/main' into clibase-all
ammario359923b
Remove periods from examples
ammario8e420dd
Fix list outputs in golden files!
ammariobbdcb7e
fixup! Fix list outputs in golden files!
ammariocc0a998
Fix scaletest descriptions
ammario8dbf57c
Fix remaining issues!
ammario3495efc
Remove cache directory
ammariode08cde
Fix cache dir?
ammario0544597
Add ErrorWaiter to clitest
ammario7bc2f82
Print aliases
ammario7c1acbf
Remove "t" alias
ammario796b527
Fix up more of the diff... through scaletest
ammario2413718
Add missing [flags]
ammarioda716cf
make update-golden-files
ammarioca9ccba
Fix some more duplication + migration issues
ammario9865ba8
make gen + messed up a bullet
ammario38110ba
Fix dotfiles description
ammario0cf7654
Fix scaletest wording
ammario0bfcbee
Put aliases in docs too
ammarioac60ecb
Fix typo in scaletest
ammario6255ddd
Remove excess whitespace from error
ammario9ebd6e9
Remove (default: false) spam
ammario85e252b
tangent: [flags] in usage linting
ammario40a6914
Automatically add [flags]
ammario5f1e374
Remove remaining ".:"
ammario3a01d94
Merge remote-tracking branch 'origin/main' into clibase-all
ammariofb4eb88
Tests pass post merge
ammario6cb6ef6
fmt & lint
ammario919f768
Hide support links since it's flagless
ammarioe6fa741
Automatically insert "rm" alias
ammario44fcba5
Remove description wrapping
ammariodcc5943
Add back consistent type helpers
ammarioed49ce5
Revert remaining bad descriptions
ammariod5af663
Merge remote-tracking branch 'origin/main' into clibase-all
ammariocdda9fe
Fix output array formatting
ammario0c5a778
Only show subcommand error when command doesn't take arguments
ammariof9679b8
Merge remote-tracking branch 'origin/main' into clibase-all
ammario9b798ed
Fix compilation errors introduced by merge
ammario907e26e
Use correct timeouts in agent tests
ammario9dca6f2
Bump up test timeout
ammarioFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Pass linter
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commitd3dab44b51a583ceeed45f878a1eda8acbfb8b5c
There are no files selected for viewing
14 changes: 6 additions & 8 deletionscli/root_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletioncli/testdata/coder_--help.golden
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletionscripts/clidocgen/main.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.