Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: convert rest of CLI to clibase#6491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ammario merged 192 commits intomainfromclibase-all
Mar 23, 2023
Merged

feat: convert rest of CLI to clibase#6491

ammario merged 192 commits intomainfromclibase-all
Mar 23, 2023

Conversation

ammario
Copy link
Member

@ammarioammario commentedMar 7, 2023
edited
Loading

Follow up from#6347

Now

  • Generate CLI docs again
  • Convert the rest of the CLI to bigcli
  • Refactor rest ofcli/server_test.go to use "clitest.Start" for better cleanup and error reporting
  • Regenerate golden files
  • Removecliflag package
  • Verify thatcobra is no longer imported
  • RemovedFormatCobraError
  • Ensure Output formatting (e.g. JSON) continues working
  • Make sure GIT ASKPASS continues working (environment variable jiu-jitsu)
  • Test ReadGitAuthEnv

Later

@ammarioammarioforce-pushed theclibase-all branch 4 times, most recently from17fa3f4 toaee8ae9CompareMarch 7, 2023 21:04
* Some commands are transitioned
* Fixed server.go
* Massive fixup in clibase command parsing
* Start the enterprise
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this is as polished as we'll get it, confirmed via golden file output tweaks that we got all the major differences ironed out and ran some manual command tests which caught a few issues, which are now fixed.

Giving a green light for merge once CI passes! 👍🏻

@ammarioammario merged commit2bd6d29 intomainMar 23, 2023
@ammarioammario deleted the clibase-all branchMarch 23, 2023 22:42
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 23, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

@kylecarbskylecarbskylecarbs left review comments

Assignees

@ammarioammario

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@ammario@mafredri@kylecarbs

[8]ページ先頭

©2009-2025 Movatter.jp