- Notifications
You must be signed in to change notification settings - Fork926
feat: convert rest of CLI to clibase#6491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
17fa3f4
toaee8ae9
Compare* RunContext -> WithContext* Stdin/Stdout wiring
* More stdio wiring
Started refactoring production code too 🥴
- Fix output formats
* SO much
* Some server.go fixes
All useclients
Pretty up cliui logs
* Everything, everywhere is broken
* Some commands are transitioned
* Fixed server.go
* Massive fixup in clibase command parsing
* Start the enterprise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this is as polished as we'll get it, confirmed via golden file output tweaks that we got all the major differences ironed out and ran some manual command tests which caught a few issues, which are now fixed.
Giving a green light for merge once CI passes! 👍🏻
Uh oh!
There was an error while loading.Please reload this page.
Follow up from#6347
Now
cli/server_test.go
to use "clitest.Start" for better cleanup and error reportingcliflag
packagecobra
is no longer importedFormatCobraError
Later
clitest.Start
.Option.Default
in favor of using whatever is stored inOption.Value
. (clibase: use Value instead of Default #6697)