Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: mark coder_parameter as "required"#6433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mtojek merged 21 commits intocoder:mainfrommtojek:6100-required-parameter-1
Mar 7, 2023
Merged
Changes from1 commit
Commits
Show all changes
21 commits
Select commitHold shift + click to select a range
d304f8b
Add required column
mtojekMar 3, 2023
110b10b
Pass through providerd
mtojekMar 3, 2023
8b3fe8c
Pass the required property down
mtojekMar 3, 2023
8198eaa
Optional
mtojekMar 6, 2023
bb1c3e2
Fix
mtojekMar 6, 2023
93b6613
Fix
mtojekMar 6, 2023
0813255
Fix
mtojekMar 6, 2023
801c4df
fix
mtojekMar 6, 2023
e804f40
CLI create: support for optional fields
mtojekMar 6, 2023
60ffd86
Use HTML API to mark fields required
mtojekMar 6, 2023
2c8be6c
Fix
mtojekMar 6, 2023
5282122
Improve validation
mtojekMar 6, 2023
659bfa2
more fixes
mtojekMar 6, 2023
e08a3af
make fmt
mtojekMar 6, 2023
44eca14
Fix
mtojekMar 6, 2023
fbcbe2e
WIP
mtojekMar 6, 2023
a688d94
Fix: test
mtojekMar 7, 2023
16927d2
CLI update tets
mtojekMar 7, 2023
d582472
OptionalParameterAdded
mtojekMar 7, 2023
6e24aa3
Merge branch 'main' into 6100-required-parameter-1
mtojekMar 7, 2023
866fef2
Fix: migration
mtojekMar 7, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
Fix: test
  • Loading branch information
@mtojek
mtojek committedMar 7, 2023
commita688d94c8e7d927ea5add18e1f9010e46c89dadf
7 changes: 2 additions & 5 deletionscoderd/workspaces_test.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1951,16 +1951,13 @@ func TestWorkspaceWithOptionalRichParameters(t *testing.T) {
require.Equal(t, secondParameterRequired, templateRichParameters[1].Required)

expectedBuildParameters := []codersdk.WorkspaceBuildParameter{
{Name: firstParameterName, Value: firstParameterDefaultValue},
// First parameter is optional, so coder will pick the default value.
{Name: secondParameterName, Value: secondParameterValue},
}

template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID)
workspace := coderdtest.CreateWorkspace(t, client, user.OrganizationID, template.ID, func(cwr *codersdk.CreateWorkspaceRequest) {
cwr.RichParameterValues = []codersdk.WorkspaceBuildParameter{
// First parameter is optional, so coder should pick the default value.
{Name: secondParameterName, Value: secondParameterValue},
}
cwr.RichParameterValues = expectedBuildParameters
})

workspaceBuild := coderdtest.AwaitWorkspaceBuildJob(t, client, workspace.LatestBuild.ID)
Expand Down

[8]ページ先頭

©2009-2025 Movatter.jp