Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: mark coder_parameter as "required"#6433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mtojek merged 21 commits intocoder:mainfrommtojek:6100-required-parameter-1
Mar 7, 2023

Conversation

mtojek
Copy link
Member

@mtojekmtojek commentedMar 3, 2023
edited
Loading

Related:#6100

This PR extends the rich parameters feature to let users mark them as optional. This behavior is consistent with Terraform variables.

A rich parameter is consideredrequired when it doesn't contain thedefault property, so:

data"coder_parameter""another_required_field" {name="Another required field"icon="/icon/aws.png"description="This string is required"mutable=true}

If we want to mark the parameter as optional, we need to add thedefault property:

data"coder_parameter""random_string" {name="Optional random string"icon="/icon/aws.png"description="This string is optional"mutable=truedefault=""}

Changes:

  • use the latest terraform-provider-coder to support computed property "optional" (not exposed to users)
  • adjust coderd API to exposerequired property
  • site: allow for empty, optional parameters
  • site: use HTML API to check if field is required
  • modify CLI to allow for entering values for newly added parameters to templates

Follow-ups:

  • present a special form or popup to enter required params without defaults (especially if those are new parameters)

bpmct and kylecarbs reacted with thumbs up emoji
@mtojekmtojek self-assigned thisMar 3, 2023
@mtojekmtojek changed the titleAdd required columnfeat: mark coder_parameter as "required"Mar 3, 2023
@mtojekmtojek marked this pull request as ready for reviewMarch 7, 2023 11:23
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Copy link
Member

@kylecarbskylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I like it!

@mtojekmtojek merged commit2d4706a intocoder:mainMar 7, 2023
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMar 7, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

@kylecarbskylecarbskylecarbs approved these changes

@bpmctbpmctAwaiting requested review from bpmct

Assignees

@mtojekmtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@mtojek@BrunoQuaresma@kylecarbs

[8]ページ先頭

©2009-2025 Movatter.jp